Merge pull request #3571 from IgniteUI/sstoyanov/bug-fix-3362

Call markForCheck in writeValue method
IgniteUI · Jan 14, 2019 · fa9379b · fa9379b
2 parents 2d1a63c + 0997a73
commit fa9379b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts b/projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
@@ -17,7 +17,8 @@ import {
     ElementRef,
     TemplateRef,
     Directive,
-    isDevMode
+    isDevMode,
+    ChangeDetectorRef
 } from '@angular/core';
 import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
 import {
@@ -445,7 +446,7 @@ export class IgxDatePickerComponent implements ControlValueAccessor, EditorProvi
 
     @ViewChild(IgxInputDirective) protected input: IgxInputDirective;
 
-    constructor(private resolver: ComponentFactoryResolver, private element: ElementRef) { }
+    constructor(private resolver: ComponentFactoryResolver, private element: ElementRef, private cdr: ChangeDetectorRef) { }
 
     /**
      *Method that sets the selected date.
@@ -462,6 +463,7 @@ export class IgxDatePickerComponent implements ControlValueAccessor, EditorProvi
      */
     public writeValue(value: Date) {
         this.value = value;
+        this.cdr.markForCheck();
     }
 
     /**

diff --git a/projects/igniteui-angular/src/lib/grids/filtering/grid-filtering-row.component.ts b/projects/igniteui-angular/src/lib/grids/filtering/grid-filtering-row.component.ts
@@ -141,11 +141,6 @@ export class IgxGridFilteringRowComponent implements AfterViewInit {
         this._conditionsOverlaySettings.outlet = this.column.grid.outletDirective;
         this._operatorsOverlaySettings.outlet = this.column.grid.outletDirective;
 
-        if (this.column.dataType === DataType.Date) {
-            // TODO: revise usage of cdr.detectChanges() here
-            this.cdr.detectChanges();
-        }
-
         this.input.nativeElement.focus();
     }