remove toggle from RowType interface, fix FinJsDemo (#10540)

* fix(grid): remove toggle from RowType interface
IgniteUI · Nov 18, 2021 · da45fe8 · da45fe8
1 parent fc338b6
commit da45fe8
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -80,7 +80,11 @@ All notable changes for each version of this project will be documented in this
         Use `IgxGridToolbarComponent`, `IgxGridToolbarHidingComponent`, `IgxGridToolbarPinningComponent` instead.
     - **Breaking Change** - The `rowSelected` event is renamed to `rowSelectionChanging` to better reflect its function.
     - **Breaking Change** - The `columnSelected` event is renamed to `columnSelectionChanging` to better reflect its function.
-    - **Breaking Change** - `columnsCollection` is removed. Use `columns` instead.
+    - **Breaking Change** - `columnsCollection` is removed. Use `columns` instead. If at certain ocasions `columns` return empty array, query the columns using `ViewChildren` and access those in `ngAfterViewInit`:
+    ```ts
+    @ViewChildren(IgxColumnComponent, { read: IgxColumnComponent })
+    public columns: QueryList<IgxColumnComponent>;
+    ```
     - `RowType`, `IgxRowDirective`
         - **Breaking Change** - `rowData` and `rowID` deprecated properties are now removed. Use `data` and `key` instead. Use `ng update` for automatic migration.
     - `igxRowSelector`

diff --git a/projects/igniteui-angular/src/lib/grids/common/grid.interface.ts b/projects/igniteui-angular/src/lib/grids/common/grid.interface.ts
@@ -105,7 +105,6 @@ export interface RowType {
     delete?: () => any;
     pin?: () => void;
     unpin?: () => void;
-    toggle?: () => void;
 }
 
 export interface ColumnType {

diff --git a/...ects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-moving.component.ts b/...ects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-moving.component.ts
@@ -80,6 +80,7 @@ export class IgxExcelStyleMovingComponent {
                     return columns[index];
                 }
             }
+            return columns[0];
         } else {
             while (index < columns.length - 1) {
                 index++;

diff --git a/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts
@@ -520,13 +520,15 @@ export class IgxGridNavigationService {
             }
         } else if (!row.expanded && ROW_EXPAND_KEYS.has(key)) {
             if (row.key === undefined) {
-                row.toggle();
+                // TODO use expanded row.expanded = !row.expanded;
+                (row as any).toggle();
             } else {
                 this.grid.gridAPI.set_row_expansion_state(row.key, true, event);
             }
         } else if (row.expanded && ROW_COLLAPSE_KEYS.has(key)) {
             if (row.key === undefined) {
-                row.toggle();
+                // TODO use expanded row.expanded = !row.expanded;
+                (row as any).toggle();
             } else {
                 this.grid.gridAPI.set_row_expansion_state(row.key, false, event);
             }

diff --git a/src/app/shared/financialData.ts b/src/app/shared/financialData.ts
@@ -895,12 +895,10 @@ export class FinancialData {
 
     /** Updates values in random records */
     public static updateRandomPrices(data: any[]): any[] {
-      const newData = data.slice();
-      // fixing a strange bug where newData has more elements than data, but all of those "explicit" items are undefined
       for (let i = Math.round(Math.random() * 10); i < data.length; i += Math.round(Math.random() * 10)) {
-          newData.push(this.randomizeObjectData(newData[i]));
+          this.randomizeObjectData(data[i]);
       }
-      return newData;
+      return Array.from(data);
     }
 
     /*** Genrates additional financial data fields */