Merge pull request #10220 from IgniteUI/dmdimitrov/exporters-import

feat(exporters): add providedIn root to exporters
IgniteUI · Oct 7, 2021 · 7fc327b · 7fc327b
2 parents 99b22a5 + 80dd86d
commit 7fc327b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 All notable changes for each version of this project will be documented in this file.
 
+## 13.0.0
+
+### New Features
+- `IgxCsvExporterService`, `IgxExcelExporterService`
+    - Exporter services are no longer required to be provided in the application since they are now injected on a root level. 
+
 ## 12.2.1
 
 ### New Features

diff --git a/projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-exporter.component.ts b/projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-exporter.component.ts
@@ -108,8 +108,8 @@ export class IgxGridToolbarExporterComponent extends BaseToolbarDirective {
 
     constructor(
         @Host() protected toolbar: IgxGridToolbarComponent,
-        @Optional() private excelExporter: IgxExcelExporterService,
-        @Optional() private csvExporter: IgxCsvExporterService,
+        private excelExporter: IgxExcelExporterService,
+        private csvExporter: IgxCsvExporterService,
     ) {
         super(toolbar);
     }

diff --git a/projects/igniteui-angular/src/lib/services/csv/csv-exporter.ts b/projects/igniteui-angular/src/lib/services/csv/csv-exporter.ts
@@ -31,7 +31,9 @@ export interface ICsvExportEndedEventArgs extends IBaseEventArgs {
  * this.csvExportService.exportData(this.localData, opt);
  * ```
  */
-@Injectable()
+@Injectable({
+    providedIn: 'root',
+})
 export class IgxCsvExporterService extends IgxBaseExporter {
     /**
      * This event is emitted when the export process finishes.

diff --git a/projects/igniteui-angular/src/lib/services/excel/excel-exporter.ts b/projects/igniteui-angular/src/lib/services/excel/excel-exporter.ts
@@ -39,7 +39,9 @@ const EXCEL_MAX_COLS = 16384;
  * this.excelExportService.exportData(this.localData, new IgxExcelExporterOptions("FileName"));
  * ```
  */
-@Injectable()
+@Injectable({
+    providedIn: 'root',
+})
 export class IgxExcelExporterService extends IgxBaseExporter {
     private static ZIP_OPTIONS = { compression: 'DEFLATE', type: 'base64' } as JSZip.JSZipGeneratorOptions<'base64'>;
 

diff --git a/src/app/app.module.ts b/src/app/app.module.ts
@@ -5,7 +5,7 @@ import { HttpClientModule, HTTP_INTERCEPTORS } from '@angular/common/http';
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { NgModule } from '@angular/core';
 import {
-    IgxIconModule, IgxBottomNavModule, IgxGridModule, IgxExcelExporterService, IgxCsvExporterService, IgxOverlayService,
+    IgxIconModule, IgxBottomNavModule, IgxGridModule, IgxOverlayService,
     IgxDragDropModule, IgxDividerModule, IgxTreeGridModule, IgxHierarchicalGridModule, IgxInputGroupModule,
     IgxIconService, DisplayDensityToken, DisplayDensity,
     IgxDateTimeEditorModule, IgxDateRangePickerModule, IgxButtonModule, IgxActionStripModule, GridBaseAPIService, IgxButtonGroupModule,
@@ -327,9 +327,7 @@ const components = [
         HierarchicalRemoteService,
         GridBaseAPIService,
         IgxGridHierarchicalPipe,
-        IgxExcelExporterService,
         IgxIconService,
-        IgxCsvExporterService,
         IgxOverlayService,
         { provide: DisplayDensityToken, useFactory: () => ({ displayDensity: DisplayDensity.comfortable }) },
         {