Skip to content

Commit

Permalink
There was still JS Blocks occurrences
Browse files Browse the repository at this point in the history
  • Loading branch information
kdinev committed Jan 31, 2018
1 parent f3476f2 commit 53c57b6
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 16 deletions.
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Overview
Ignite UI JS Blocks version accepts contributions, as long as they follow the guidelines explained below. When contributing you would have to follow these steps:
Ignite UI for Angular version accepts contributions, as long as they follow the guidelines explained below. When contributing you would have to follow these steps:

1. Fork the repository
2. Perform the changes in your fork
Expand All @@ -16,13 +16,13 @@ In order to perform all the necessary checks before pulling your changes in, you
[CSS Naming Convention](https://github.com/IgniteUI/igniteui-angular/blob/master/css-naming-convention.md)

# Workflow
When working on an issue for the Ignite UI JS Blocks repository, you need to be aware of and to follow a correct status workflow. We have created a number of status labels in order to communicate well what the current status of a single issue/pull request is. The statuses are as follows:
When working on an issue for the Ignite UI for Angular repository, you need to be aware of and to follow a correct status workflow. We have created a number of status labels in order to communicate well what the current status of a single issue/pull request is. The statuses are as follows:

## Development - applicable to issues and pull requests
1. `status: in-review` this is the initial status of an issue. If the label is not placed, go ahead and place it.
2. `status: in-development` this is the status once you start working on an issue. Assign the issue to yourself if it hasn't been assigned already and remove the previous status and assign it an in development status.
3. `status: by-design` this is the status of an issue that has been reviewed and has been determined that the current design of the feature is such that the issue describes the correct behavior as incorrect. Remove other statuses and place this status if you've reviewed the issue.
4. `status: third-party-issue` this is the status of an issue that has been reviewed, has been determined to be an issue, but the root case is not in the Ignite UI JS Blocks code. Example would be browser specific bugs caused by the particular browser's rendering or JavaScript engines, or an issue with the Angular framework. Remove other statuses and place only this one if you're the one performing the investigation.
4. `status: third-party-issue` this is the status of an issue that has been reviewed, has been determined to be an issue, but the root case is not in the Ignite UI for Angular code. Example would be browser specific bugs caused by the particular browser's rendering or JavaScript engines, or an issue with the Angular framework. Remove other statuses and place only this one if you're the one performing the investigation.
5. `status: not-to-fix` this is the status of issues that derive from our code, but have been decided to leave as is. This is done when fixes require general design and/or architecture changes and are very risky.

## Testing - applicable to pull requests
Expand Down
4 changes: 2 additions & 2 deletions css-naming-convention.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Ignite UI JS Blocks CSS Naming Convention
# Ignite UI for Angular CSS Naming Convention

Ignite UI JS Blocks uses the Two Dashes style of the [BEM naming convention](https://en.bem.info/methodology/naming-convention/) for CSS classes.
Ignite UI for Angular uses the Two Dashes style of the [BEM naming convention](https://en.bem.info/methodology/naming-convention/) for CSS classes.

Naming Convention:

Expand Down
2 changes: 1 addition & 1 deletion demos/app/app.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[(pin)]="drawerState.pin" [width]="drawerState.width" [position]="drawerState.position">
<div class="ig-drawer-content">
<nav class="nav">
<img class="logo" src="images/rsrcs/jsblocks-logo.svg" alt="Ignite UI JS Blocks Logo">
<img class="logo" src="images/rsrcs/jsblocks-logo.svg" alt="Ignite UI for Angular Logo">

<!--Components-->
<span class="nav-item header">Components</span>
Expand Down
2 changes: 1 addition & 1 deletion demos/app/navbar/sample.component.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Location } from "@angular/common";
import { Component, OnInit } from "@angular/core";

const CURRENT_VIEW: string = "Ignite UI JS Blocks Samples";
const CURRENT_VIEW: string = "Ignite UI for Angular Samples";

@Component({
selector: "navbar-sample",
Expand Down
2 changes: 1 addition & 1 deletion demos/app/styleguide/typography/sample.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<section class="sample-content">
<article class="sample-column">
<h4 class="sample-title">Typeface</h4>
<p>Ignite UI JS Blocks uses <a href="https://fonts.google.com/specimen/Titillium+Web">Titillium Web</a> as the font
<p>Ignite UI for Angular uses <a href="https://fonts.google.com/specimen/Titillium+Web">Titillium Web</a> as the font
of choice. It is highly optimized for the web, legible, and pairs great with Google's own <a href="https://fonts.google.com/specimen/Roboto">Roboto</a>.</p>
</article>
<article class="sample-column">
Expand Down
2 changes: 1 addition & 1 deletion demos/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const config = {

new HtmlWebpackPlugin({
template: path.resolve(__dirname, 'index.ejs'),
title: "IgniteUI Js Blocks Samples",
title: "IgniteUI for Angular Samples",
inject: 'body'
}),

Expand Down
4 changes: 2 additions & 2 deletions src/animations/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Animations

Ignite UI JS Blocks includes over 100+ pre-built animations. They are split in 7 groups:
Ignite UI for Angular includes over 100+ pre-built animations. They are split in 7 groups:

- [Fade](https://github.com/IgniteUI/igniteui-angular/tree/master/src/animations/fade/README.md)
- [Flip](https://github.com/IgniteUI/igniteui-angular/tree/master/src/animations/flip/README.md)
Expand Down Expand Up @@ -50,7 +50,7 @@ Some of the animations from the Flip, Rotate, and Swing groups require the paren

# Timing Functions

Ignite UI JS Blocks includes a set of timing functions that can be used to ease in or out an animation.
Ignite UI for Angular includes a set of timing functions that can be used to ease in or out an animation.
There are three main timing function groups - **EaseIn**, **EaseOut**, and **EaseInOut**; each containing the following timings:

- quad
Expand Down
2 changes: 1 addition & 1 deletion src/button/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The **igxButton** directive is intended to be used on any button, span, div, or

# Examples

Using `igxButton` to turn a span element into an js blocks styled button.
Using `igxButton` to turn a span element into an for Angular styled button.
```html
<span igxButton="raised" igxButtonColor="yellow" igxButtonBackground="#000">Click me<span>
```
2 changes: 1 addition & 1 deletion src/buttonGroup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ The **igx-ButtonGroup** component aims at providing a button group functionality

# Examples

Using `igx-ButtonGroup` to organize buttons into an js blocks styled button group.
Using `igx-ButtonGroup` to organize buttons into an for Angular styled button group.
```html
<igx-buttongroup multiSelection="false" [values]="buttons" [alignment]="alignment">
</igx-buttongroup>
Expand Down
2 changes: 1 addition & 1 deletion src/label/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The **igxLabel** directive is intended to be used on single-line text elements t
```
# Examples

Using `igxButton` to turn a span element into an js blocks styled button.
Using `igxButton` to turn a span element into an for Angular styled button.
```html
<span igxLabel>Single line text<span>
```
2 changes: 1 addition & 1 deletion src/themes/material/_config.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Ignite UI JS Blocks Variables //
// Ignite UI for Angular Variables //
// Table of Contents: //
// 1. Colors
// 2. Badges
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"ignoreCompilerErrors": true,
"excludePrivate": true,
"excludeNotExported": true,
"name": "IgniteUI JS Blocks",
"name": "Ignite UI for Angular",
"target": "ES5",
"moduleResolution": "node",
"preserveConstEnums": true,
Expand Down

0 comments on commit 53c57b6

Please sign in to comment.