Merge pull request #10320 from IgniteUI/dTsvetkov/fix-10172-12.2

fix(grid): fix getCellByColumn with virtualization #10172
IgniteUI · Oct 20, 2021 · 35ce159 · 35ce159
2 parents ebf3867 + 25f809b
commit 35ce159
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts b/projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts
@@ -251,10 +251,16 @@ export class IgxGridNavigationService {
     }
 
     public isDataRow(rowIndex: number, includeSummary = false) {
+        let curRow: any;
+
         if (rowIndex < 0 || rowIndex > this.grid.dataView.length - 1) {
-            return false;
+            curRow = this.grid.dataView[rowIndex - this.grid.virtualizationState.startIndex];
+            if (!curRow){
+                return false;
+            }
+        } else {
+            curRow = this.grid.dataView[rowIndex];
         }
-        const curRow = this.grid.dataView[rowIndex];
         return curRow && !this.grid.isGroupByRecord(curRow) && !this.grid.isDetailRecord(curRow)
             && !curRow.childGridsData && (includeSummary || !curRow.summaries);
     }

diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
@@ -1029,7 +1029,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType,
      * @param index
      */
     public getRowByIndex(index: number): RowType {
-        if (index < 0 || index >= this.dataView.length) {
+        if (index < 0) {
             return undefined;
         }
         return this.createRow(index);
@@ -1140,8 +1140,16 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType,
      */
     public createRow(index: number, data?: any): RowType {
         let row: RowType;
+        let rec: any;
 
-        const rec: any = data ?? this.dataView[index];
+        if (index < 0 || index >= this.dataView.length) {
+            if (index >= this.dataView.length){
+                const virtIndex = index - this.gridAPI.grid.virtualizationState.startIndex;
+                rec = data ?? this.dataView[virtIndex];
+            }
+        } else {
+            rec = data ?? this.dataView[index];
+        }
 
         if (rec && this.isGroupByRecord(rec)) {
             row = new IgxGroupByRow(this, index, rec);