Merge pull request #11243 from IgniteUI/mkirova/pivot-minor-perf-impr

PivotGrid Minor performance improvements
IgniteUI · Mar 21, 2022 · 31b8421 · 31b8421
2 parents 4c767d6 + c13bc3d
commit 31b8421
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/projects/igniteui-angular/src/lib/directives/for-of/for_of.directive.ts b/projects/igniteui-angular/src/lib/directives/for-of/for_of.directive.ts
@@ -1464,6 +1464,9 @@ export class IgxGridForOfDirective<T> extends IgxForOfDirective<T> implements On
     @Input()
     public igxGridForOfUniqueSizeCache = false;
 
+    @Input()
+    public igxGridForOfVariableSizes = true;
+
     public get igxGridForOf() {
         return this.igxForOf;
     }
@@ -1494,6 +1497,12 @@ export class IgxGridForOfDirective<T> extends IgxForOfDirective<T> implements On
         return this.igxForSizePropName || 'height';
     }
 
+    public recalcUpdateSizes() {
+        if (this.igxGridForOfVariableSizes) {
+            super.recalcUpdateSizes();
+        }
+    }
+
     /**
      * @hidden @internal
      * An event that is emitted after data has been changed but before the view is refreshed

diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.html b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.html
@@ -41,6 +41,7 @@
             let-rowIndex="index" [igxForScrollOrientation]="'vertical'" [igxForScrollContainer]='verticalScroll'
             [igxForContainerSize]='calcHeight'
             [igxForItemSize]="hasColumnLayouts ? rowHeight * multiRowLayoutRowSize + 1 : renderedRowHeight"
+            [igxGridForOfVariableSizes]='false'
             #verticalScrollContainer>
             <ng-template
                 [igxTemplateOutlet]='recordTemplate'

diff --git a/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.ts b/projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-header-row.component.ts
@@ -273,7 +273,7 @@ export class IgxPivotHeaderRowComponent extends IgxGridHeaderRowComponent implem
     */
     public getAreaHeight(area: IgxChipsAreaComponent) {
         const chips = area.chipsList;
-        return chips && chips.length > 0 ? chips.first.nativeElement.clientHeight : 0;
+        return chips && chips.length > 0 ? chips.first.nativeElement.offsetHeight : 0;
     }
 
     /**