refactor(icon-service): simplify family initialization

IgniteUI · Sep 28, 2021 · 02de7a8 · 02de7a8
1 parent e95d257
commit 02de7a8
Showing 1 changed file with 6 additions and 21 deletions.
diff --git a/projects/igniteui-angular/src/lib/icon/icon.service.ts b/projects/igniteui-angular/src/lib/icon/icon.service.ts
@@ -182,22 +182,6 @@ export class IgxIconService {
         return req;
     }
 
-    /**
-     * @hidden
-     */
-    private getOrCreateIconFamily(name: string) {
-        let family: Map<string, string>;
-
-        if(this._cachedSvgIcons.has(name)) {
-            family = this._cachedSvgIcons.get(name) as Map<string, string>;
-        } else {
-            family = new Map<string, string>();
-            this._cachedSvgIcons.set(name, family);
-        }
-
-        return family;
-    }
-
     /**
      * @hidden
      */
@@ -207,13 +191,14 @@ export class IgxIconService {
             div.innerHTML = value;
             const svg = div.querySelector('svg') as SVGElement;
 
-            if(svg) {
+            if (!this._cachedSvgIcons.has(family)) {
+                this._cachedSvgIcons.set(family, new Map<string, string>());
+            }
+
+            if (svg) {
                 svg.setAttribute('fit', '');
                 svg.setAttribute('preserveAspectRatio', 'xMidYMid meet');
-                const svgText = svg.outerHTML;
-
-                const familyRegistry = this.getOrCreateIconFamily(family);
-                familyRegistry.set(name, svgText);
+                this._cachedSvgIcons.get(family).set(name, svg.outerHTML);
             }
         }
     }