fix(grid,filtering): clear filter with empty input #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
14 tasks
gedinakova
approved these changes
Oct 28, 2024
gedinakova
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Filtering samples for Grid & Tree Grid, when you enter a filter value the Filter UI chip on the respective column is added, except when the filter input is cleared it remains with no value:
https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/filtering#angular-grid-filtering-example
https://www.infragistics.com/products/ignite-ui-angular/angular/components/treegrid/filtering#angular-tree-grid-filtering-example
Technically the same should be applied to the Boston Marathon and Filter template samples, since those do the same, except the UI is not active and thus isn't visible.Strike that, the Filter template samples actually have a check and clear, leaving just the landing grid sample, so I'll just go ahead and update it as well.