Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-editing(sass): fall back to libsass #2747

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Jul 21, 2021

Aleksandyr
Aleksandyr previously approved these changes Jul 22, 2021
@zdrawku
Copy link
Contributor

zdrawku commented Jul 22, 2021

@simeonoff @Aleksandyr, StackBlitz is working properly now, with the new alpha.6, although CodeSandBox is still returning an error:

Example:
https://codesandbox.io/s/kvusw

image

@simeonoff
Copy link
Collaborator Author

simeonoff commented Jul 22, 2021

@simeonoff @Aleksandyr, StackBlitz is working properly now, with the new alpha.6, although CodeSandBox is still returning an error:

Example:
https://codesandbox.io/s/kvusw

image

@zdrawku That's unfortunate. Will see if I can muster another hack in another alpha.

Edit: It's actually a fairly simple fix. Pushing.

@simeonoff
Copy link
Collaborator Author

@Aleksandyr try again, it should work now.

@zdrawku zdrawku merged commit 8ccd0cd into vNext Jul 22, 2021
@zdrawku zdrawku deleted the simeonoff/live-editing-libsass branch July 22, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants