Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESF Load On Demand samples #1390

Merged
merged 22 commits into from
Sep 2, 2019
Merged

Add ESF Load On Demand samples #1390

merged 22 commits into from
Sep 2, 2019

Conversation

tachojelev
Copy link
Contributor

@tachojelev tachojelev commented Aug 12, 2019 •
edited by DiyanDimitrov
Loading

Closes #1392

@tachojelev tachojelev changed the title Add ESF Load On Demand sample Add ESF Load On Demand samples Aug 13, 2019
@tachojelev tachojelev marked this pull request as ready for review August 14, 2019 08:30
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 16, 2019
View reviewed changes
zdrawku
zdrawku reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tachojelev the build is failing with the following error:

Can't bind to 'uniqueColumnValuesStrategy' since it isn't a known property of 'igx-tree-grid'

@tachojelev
Copy link
Contributor Author

@tachojelev the build is failing with the following error:

Can't bind to 'uniqueColumnValuesStrategy' since it isn't a known property of 'igx-tree-grid'

@zdrawku, the build is failing with this error, because the 'uniqueColumnValuesStrategy' property is a new property, that is present only in our master branch of igniteui-angular. Once we have a tagged version of igniteui-angular's master and we update the package.json of the samples with the new version, the build should pass and then we can merge it.

@DiyanDimitrov DiyanDimitrov changed the base branch from master to vNext August 27, 2019 06:08
@DiyanDimitrov DiyanDimitrov self-requested a review August 27, 2019 06:09
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 27, 2019
View reviewed changes
@zdrawku
Copy link
Contributor

zdrawku commented Aug 27, 2019

I've made a PR to vNext branch with the upgrade, once it is merged I will update this branch

@DiyanDimitrov DiyanDimitrov self-requested a review August 28, 2019 14:14
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 28, 2019
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review September 2, 2019 12:47
@DiyanDimitrov DiyanDimitrov merged commit 3fc9d45 into vNext Sep 2, 2019
@DiyanDimitrov DiyanDimitrov deleted the tzhelev/esf-load-on-demand-sample branch September 2, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku left review comments

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees

@rmkrmk rmkrmk

Labels
grid hierarchical-grid status: verified tree-grid version: 8.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tachojelev @zdrawku @DiyanDimitrov @rmkrmk