Install VSCodium and make host .application file #86
Conversation
justinmichaud
commented
Jan 16, 2025
justinmichaud
commented
- Work around lldb python issues
- Install VSCodium by default
- Add helpful clangd default settings
- Make VSCode .application file by default
- Install VSCodium by default - Add helpful clangd default settings - Make VSCode .application file by default
| Name=VSCode WKDev | ||
| Comment=Code Editing. Redefined. | ||
| GenericName=Text Editor | ||
| Exec=bash -c "source /home/${USER}/.bashrc; wkdev enter -I -e -- $CODE_EXEC" |
There was a problem hiding this comment.
| Exec=bash -c "source /home/${USER}/.bashrc; wkdev enter -I -e -- $CODE_EXEC" | |
| Exec=bash -c "source /home/${USER}/.bashrc; wkdev-enter --exec --no-interactive -- $CODE_EXEC --unity-launch %F" |
code takes a list of files.
explict args are more readable.
There was a problem hiding this comment.
This makes a strong assumption users configure bash, which just isn't true.
This needs to be changed to be an absolute path to wkdev-enter on the host. I'm not sure how to get that information off-hand.
| Icon=vscode-wkdev | ||
| Type=Application | ||
| StartupNotify=false | ||
| StartupWMClass=VSCodium |
| } | ||
|
|
||
| install_icon() { | ||
| cp /usr/share/pixmaps/vscod*.png /host/${HOME}/.local/share/icons/vscode-wkdev.png |
There was a problem hiding this comment.
This should go in a size appropriate subdirectory, e.g. ~/.local/share/icons/hicolor/256x256/apps/
| Categories=TextEditor;Development;IDE; | ||
| MimeType=text/plain;inode/directory;application/x-codium-workspace; | ||
| Keywords=vscodium;codium;vscode; | ||
|
|
There was a problem hiding this comment.
Just to match the normal desktop file:
[Desktop Action new-empty-window]
Name=New Empty Window
Exec=${SAME EXEC AS ABOVE MINUS UNITY} --new-window %F
Icon=vscode-wkdev| } | ||
|
|
||
| install_xdg() { | ||
| tee /host/${HOME}/.local/share/applications/codium.desktop << HERE |
There was a problem hiding this comment.
Hardcoded name referring to vscodium.
| "editorWhitespace.background": "#FF0000" | ||
| }, | ||
| "terminal.integrated.allowChords": false, | ||
| } |
There was a problem hiding this comment.
Some of these are pretty arbitrary. I like the clangd.arguments but maybe lets move this to a different PR to discuss.
| @@ -239,6 +253,7 @@ TASKS=( | |||
| "try_setup_dockerenv_file" | |||
| "try_setup_permissions_jhbuild_directory" | |||
| "try_setup_permissions_rust_directory" | |||
| "try_fix_lldb_py" | |||
There was a problem hiding this comment.
Please move this to its own PR.
| @@ -17,8 +17,10 @@ verify_executables_exist curl | |||
| argsparse_allow_no_argument true | |||
| argsparse_use_option "=yes" "Assume yes for all prompts." | |||
| argsparse_use_option "no-extensions" "Don't install extensions." | |||
| argsparse_use_option "proprietary" "Use proprietary VSCode." | |||
There was a problem hiding this comment.
I understand people have strong opinions on this but I would prefer the default being normal vscode.
I can accept vscodium as an opt-in option but the reality is it will be less tested.
