Implement Implicit "OR" #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpino
added a commit
that referenced
this pull request
Aug 14, 2014
If an identifier is given without a keyword, the most recent keyword is assumed. For example, not host vs and ace is short for not host vs and host ace Which should not be confused with not ( host vs or ace ) This patch fixes issue #17.
dpino
force-pushed
the
issue-17-implement-implicit-or
branch
from
2f685f2
to
51f6da1
Compare
dpino
added a commit
that referenced
this pull request
Sep 3, 2014
If an identifier is given without a keyword, the most recent keyword is assumed. For example, not host vs and ace is short for not host vs and host ace Which should not be confused with not ( host vs or ace ) This patch fixes issue #17.
If an identifier is given without a keyword, the most recent keyword is assumed. For example, not host vs and ace is short for not host vs and host ace Which should not be confused with not ( host vs or ace ) This patch fixes issue #17.
dpino
force-pushed
the
issue-17-implement-implicit-or
branch
from
51f6da1
to
edd2622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pflang documentation says:
Pflua currently does not implement implicit OR, and probably should do so. Steve McCanne seemed to think it was pretty important in http://sharkfest.wireshark.org/sharkfest.11/presentations/McCanne-Sharkfest'11_Keynote_Address.pdf, though I find it to be a source of ambiguity in the language.