Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Make identity server work with publish single file in .NET 5.0 #4868

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

javiercn
Copy link
Contributor

What issue does this PR address?
#4810

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)
    I couldn't find unit tests in the area testing the current behavior, I'm happy to add one if you point me where to do so.

Other information:
Manual validation of the changes.
image

@leastprivilege leastprivilege added this to the 4.1.0 milestone Sep 11, 2020
@leastprivilege leastprivilege merged commit 24b1523 into IdentityServer:main Sep 11, 2020
@leastprivilege
Copy link
Member

thanks!

@brockallen
Copy link
Member

Was this change backwards compat w/ 3.1?

@javiercn
Copy link
Contributor Author

@brockallen it should, but this is not an issue in 3.1 since the publish single file strategy is different (the assemblies we packaged and unzipped on a temp directory, while now they are mapped directly into memory, so there's no physical file at all, which was the root cause of the issue).

In general, is not "safe" to use Assembly.Location AFAIK if you want to support publish single file, we had to do work in MVC too to avoid issues there too.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants