Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

fix multiple WWW-Authenticate header to one #4712

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

mouxhun
Copy link
Contributor

@mouxhun mouxhun commented Aug 5, 2020

WWW-Authenticate header should only have one

What issue does this PR address?
every WWW-Authenticate header should atleast have one auth schema, because we only used bearer token authentication, we should only have one WWW-Authenticate header.Currently it returns two likes below

WWW-Authenticate: Bearer
WWW-Authenticate: error="invalid_token"

test on https://demo.identityserver.io/connect/userinfo

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

WWW-Authenticate header should only have one
@stale
Copy link

stale bot commented Aug 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Questions are community supported only and the authors/maintainers may or may not have time to reply. If you or your company would like commercial support, please see here for more information.

@stale stale bot added the wontfix label Aug 19, 2020
@mouxhun
Copy link
Contributor Author

mouxhun commented Aug 19, 2020

reference https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.47

The field value consists of at least one challenge that indicates the authentication scheme(s) and parameters applicable to the Request-URI

the second one don't have schema

@brockallen brockallen merged commit 875fe1d into IdentityServer:main Sep 7, 2020
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants