This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Allow setting SameSite mode of the SessionId cookie #4711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
The SameSite mode of the sessionId cookie can be configured with this PR. It was hardcoded to
SameSiteMode.None
before.We set this to
SameSiteMode.Lax
for serving via http for local development (in a docker instance), where SameSite=None cookies get ignored (Chrome 84). SameSite=None only works for Secure cookies.Does this PR introduce a breaking change?
No. The default is still
SameSiteMode.None
Please check if the PR fulfills these requirements
Other information: