Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

fix infinite loop in Token Cleanup after concurrency exception #4498

Merged

Conversation

brockallen
Copy link
Member

Copy link
Contributor

@ArturDorochowicz ArturDorochowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no EF expert, but I think it will work. One thing to note is that you don't inspect the type of the conflicted entry and make an assumption that these are all persisted grants. Probably ok.

@brockallen
Copy link
Member Author

One thing to note is that you don't inspect the type of the conflicted entry and make an assumption that these are all persisted grants.

Yea, as I was working on it I did have that type of check and realized given the nature of what this was being used for I felt it was unnecessary.

@brockallen brockallen merged commit 3fef0b0 into master Jun 11, 2020
@brockallen brockallen deleted the features/handle_concurrency_errors_in_token_cleanup branch June 11, 2020 13:55
@ArturDorochowicz
Copy link
Contributor

@brockallen Any chance for 3.1 release with this? 🤞

@aadreja
Copy link

aadreja commented Jul 13, 2020

#4492

@brockallen I am using 4.0.2 and facing same error. Can you help

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants