Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Add JAR support #4024

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Add JAR support #4024

merged 4 commits into from
Feb 4, 2020

Conversation

leastprivilege
Copy link
Member

This PR changes the request object logic to be compatible with both OIDC ROs and JAR

@leastprivilege leastprivilege self-assigned this Jan 28, 2020
@leastprivilege leastprivilege added this to the 4.0 milestone Jan 28, 2020
@steinarnoem
Copy link

steinarnoem commented Jan 28, 2020

Have you decided on whether or not to handle the "very-special-case" of symmetrically encrypted ROs in a JAR request without OAuth 2.0 parameters (iow: no client_id)?

@leastprivilege
Copy link
Member Author

I support both client_id inside only - or in and outside the RO. But inside always takes precedence. And all inside values overwrite the outside values (if that makes sense).

@steinarnoem
Copy link

steinarnoem commented Jan 28, 2020

That is good! But I was referring to the case where there are no OAuth parameters (outside the RO) and the RO, for some unknown reason, is encrypted using a symmetric crypto algorithm. How would you find the correct key to decrypt?
I don't really think that it's a probable scenario, but maybe something that should be explicitly mentioned in the docs? Or just: "use the RAR endpoint to ensure confidentiality" :)

@leastprivilege
Copy link
Member Author

Well - this would not work. If it is symmetrically encrypted then the client_id needs to be outside the RO (but must match the one inside).

But that all hypothetical since we don't support encrypted ROs ;)

@brockallen brockallen merged commit 3d0a922 into master Feb 4, 2020
@brockallen brockallen deleted the features/jar branch February 4, 2020 15:39
@lock
Copy link

lock bot commented Mar 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants