Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Port "private_key_jwt" from IdentityServer3 #325

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

yuriyostapenko
Copy link
Contributor

Port "private_key_jwt" from IdentityServer3

  • Full certificate X5c header support removed from the implementation for
    simplicity (since they are extremely rarely used and not well supported
    anyway).
  • Improve SecretParser: Keep trying other parsers if found secret is "NoSecret"
  • Add integration tests for client assertion

Closes #27

Full certificate X5c header support removed from the implementation for
simplicity (since they are extremely rarely used and not well supported
anyway).
…oSecret"

This lifts assumption that the first found secret is "the best" available.
Add integration tests for client assertion.
@dnfclas
Copy link

dnfclas commented Sep 20, 2016

Hi @uncleyo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@leastprivilege
Copy link
Member

Cool. thanks! I will have a closer look over the weekend!

@leastprivilege leastprivilege self-assigned this Sep 21, 2016
@leastprivilege leastprivilege added this to the RC2 milestone Sep 21, 2016
@leastprivilege leastprivilege merged commit 64d6046 into IdentityServer:dev Sep 28, 2016
@lock
Copy link

lock bot commented Jan 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants