Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Add AddPersistedGrantStore<T> extension method for IIdentityServerBuilder #2783

Merged

Conversation

thomaslevesque
Copy link
Contributor

What issue does this PR address?

There are already methods to add most services (IClientStore, IResourceStore, IProfileService, etc.), but not IPersistedGrantStore. There's only AddInMemoryPersistedGrants, which isn't appropriate in many situations (in my case I need to persist refresh tokens).

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features): There are no tests for the existing methods, and a test for this doesn't seem to add much value. I'll add a test anyway if you want me to.

Other information:

N/A

@leastprivilege
Copy link
Member

thanks!

@leastprivilege leastprivilege merged commit 3d99cee into IdentityServer:dev Nov 7, 2018
@leastprivilege leastprivilege added this to the 2.3 milestone Nov 7, 2018
@thomaslevesque thomaslevesque deleted the add-persisted-grant-store branch November 7, 2018 11:11
@thomaslevesque
Copy link
Contributor Author

Thanks for the merge!

@lock
Copy link

lock bot commented Jan 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants