Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Log full exceptions when available to aid in debugging #1948

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

johnrutherford
Copy link
Contributor

What issue does this PR address?

This is related to issue #1946. Made changes to log full exceptions rather than just exception messages. This will aid in debugging since the full exception information, including inner exceptions will be available in logs.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features) N/A

Other information:

I was initially just going to do this in the ProtectedDataMessageStore class, but I found several other places where a full exception could be logged rather than just the exception message.

@dnfclas
Copy link

dnfclas commented Jan 5, 2018

CLA assistant check
All CLA requirements met.

@leastprivilege
Copy link
Member

thanks!

@leastprivilege leastprivilege added this to the 2.1.1 milestone Jan 6, 2018
@brockallen
Copy link
Member

Thanks!

@brockallen brockallen merged commit 2fec5db into IdentityServer:dev Jan 8, 2018
@brockallen brockallen added the bug label Jan 8, 2018
@lock
Copy link

lock bot commented Jan 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants