Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

/resources claim still present in IdentityServerTools #3775

Closed
leastprivilege opened this issue Oct 29, 2019 · 3 comments
Closed

/resources claim still present in IdentityServerTools #3775

leastprivilege opened this issue Oct 29, 2019 · 3 comments
Labels
bug
Milestone
3.1

Comments

@leastprivilege
Copy link
Member

Needs updating

#3774
@leastprivilege leastprivilege added this to the 3.0.3 milestone Oct 29, 2019
@rafanoronha
Copy link

rafanoronha commented Oct 29, 2019 •
edited
Loading

seems like a pretty straight forward fix, can I open a PR to address this?
no prior background with this ISTools class though
@leastprivilege do you want to drop the claim or maybe emit it based on that recent flag? not sure if the flag/options do make sense there

@leastprivilege
Copy link
Member Author

Oh - didn't see this. I already fixed it.

Thanks!

adozenlines added a commit to adozenlines/IdentityServer4 that referenced this issue Nov 12, 2019
@adozenlines
Merge branch 'master' into develop
52cf10d 
* master: (105 commits)
  Bump McMaster.Extensions.CommandLineUtils from 2.4.0 to 2.4.4 (IdentityServer#3812)
  Updated EF Quickstart (IdentityServer#3809)
  Bump Serilog.AspNetCore from 3.1.0 to 3.2.0 (IdentityServer#3811)
  Bump Microsoft.NET.Test.Sdk from 16.3.0 to 16.4.0 (IdentityServer#3800)
  Update Bug_report.md
  Some backslashes needed quoting (IdentityServer#3794)
  moved old qs code to deprecated folder
  Bump Microsoft.SourceLink.GitHub (IdentityServer#3789)
  update deps
  fix build.sh
  add key material to be able to test different algorithms
  re-enable test
  2nd look at failing test
  fix main.cmd
  add test to prove that custom claims in extensions grants get copied to refreshed token
  add test for extension grant with custom claim
  use config flag to emit audience claim in IdentityServerTools (closes IdentityServer#3775)
  Adding the nuget package dependency (IdentityServer#3759)
  fix typo (IdentityServer#3767)
  Update SPONSORS.md
  ...

# Conflicts:
#	src/AspNetIdentity/host/Host.csproj
#	src/EntityFramework/host/Host.csproj
@leastprivilege leastprivilege modified the milestones: 3.0.3, 3.1 Dec 4, 2019
@lock
Copy link

lock bot commented Jan 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@rafanoronha @leastprivilege