This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
implemented paging in ITransientDataRepository #920
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a work in progress as I was trying to figure out how to add paging but I soon started to see it go gown a rabbit hole and would alter a lot of calls. My idea was to keep the default behavior available, hence the nullable parameters, but allow for paging when sensible.
I think this should be included, I was considering switching an app that I have to currently runs on a custom (OAuth2-ish) solution based on JWT to IdentityServer but we so far have tens of thousands of refresh tokens and i'd feel wary of loading all this records at once.
Is a PR like this welcome? If so, i'll continue to adapt the other methods and finish it.
It fixes issue #853