This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
convert use of URI to string in models #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,17 +73,17 @@ public class Client | |||
| /// <summary> | |||
| /// Specifies allowed URIs to return tokens or authorization codes to | |||
| /// </summary> | |||
| public List<Uri> RedirectUris { get; set; } | |||
| public ICollection<string> RedirectUris { get; set; } | |||
There was a problem hiding this comment.
I don't really like ICollection - since this Model is used to define clients in code manually - List<T> plays much nicer with intellisense.
There was a problem hiding this comment.
it is not about linq - it is about being able to press tab in VS (and not getting #if)
There was a problem hiding this comment.
I don't follow (or agree), but that's ok -- I reverted it back.
|
looks good now |
|
I'll do this merge friday or over the weekend -- it'll require many updates in the samples. |
leastprivilege
added a commit
that referenced
this pull request
Dec 11, 2014
convert use of URI to string in models
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for discussion