Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

prompt=login support appears broken :/ #125

Closed
ciaranj opened this issue Jun 2, 2014 · 0 comments
Closed

prompt=login support appears broken :/ #125

ciaranj opened this issue Jun 2, 2014 · 0 comments

Comments

@ciaranj
Copy link
Contributor

ciaranj commented Jun 2, 2014

Looks to me like the AuthorizeInteractionResponseGenerator#ProcessLogin method needs a minor tweak.

For a client requesting prompt=login and not-yet-authenticated, they were being double-challenged.

I believe this is because the branch

if (!user.Identity.IsAuthenticated)

should contain a clause within that does

request.Raw.Remove(Constants.AuthorizeRequest.Prompt);

As happens when a user is already authenticated, but a login-prompt has been requested. (otherwise un-authenticated users get a double challenge.)

This fix is a literal fix, and re-ordering the existing branches may actually make sure, but wasn't 100% :)

leastprivilege added a commit that referenced this issue Jun 10, 2014
Fixes #125 - Avoid double-prompting on initial login
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant