Fix-bug07-phase2 #135
Open
Fix-bug07-phase2 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MonishaSivanathan
commented
Jan 6, 2025
MonishaSivanathan
commented
- changed the constant value take_test_at to service_location
- raised an exception while updating the master lab result
tamsud
requested changes
Jan 6, 2025
controller/master_controller.py
Outdated
| @@ -313,6 +313,11 @@ def fetch_data(table_name: str, coding: MasterModel): | |||
| def update_master_data(table_name: str, resource_id: str, data: CreateMasterModel): | |||
| if table_name not in MasterClient.table: | |||
| raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=f"Kindly, verify the name.") | |||
| if data.code and table_name == "lab_test": | |||
There was a problem hiding this comment.
Have you tried to update any other value with the same existing code?
There was a problem hiding this comment.
but @tamsud what they asked is if they give the cose 2nd time i have to raise exception
There was a problem hiding this comment.
For the same code if i try to update the other field what would happen
There was a problem hiding this comment.
it wont update it will raise exception tamil, can you help me what to do in this scenario
tamsud
requested changes
Jan 6, 2025
| @@ -48,7 +48,7 @@ def create_master_entries(table_name: str, data: CreateMasterModel): | |||
| code_values = MasterClient.get_by_code(MasterClient.table[table_name], data.code) | |||
| code_entry = code_values.get("entry", []) | |||
| if code_entry: | |||
| raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=f"Code already exists for {table_name}.") | |||
| raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=f"Code already exists, Please use a unique code") | |||
There was a problem hiding this comment.
Do not make this king of error again, or you copy pasting it from some other function.?
There was a problem hiding this comment.
i have copied from the create function tamil
MonishaSivanathan
force-pushed
the
Fix-bug07-phase2
branch
from
3ff8da2 to
a753d60
Compare
- changed the constant value take_test_at to service_location - raised an exception while updating the master lab result
MonishaSivanathan
force-pushed
the
Fix-bug07-phase2
branch
from
a753d60 to
9667332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.