-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Migrate analyzer script to Ruby #251
Draft
gaelfoppolo
wants to merge
30
commits into
Idean:develop
Choose a base branch
from
gaelfoppolo:feature/ruby-script
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide a more robust, extensible & maintainable analyzer script, I think it's time to drop Shell and move to Ruby. It offers so many possibilities, not available to Shell. Another PR is about using Fastlane (which is also written in Ruby) instead of the Shell script, but I don't like relying on another tool.
I've already began to convert the Shell script to a Ruby one. This is a very first version, that will demand some work and refinement before being enough stable. This is based on the work on the branch experiment/simpler-sonar-script.
My main concern resides in its location ; I would prefer to open a new repository dedicated to the analyzer, instead of mixing plugin and analyzer here. This approach is adopted by other plugin such as PowerShell. This analyzer could be available as a Gem and/or a Brew.