Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions for easier navigation on icinga.com #9217

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

bobapple
Copy link
Member

@bobapple bobapple commented Feb 16, 2022

This PR:

  • Splits installation documentation into separate Operating System navigation items for icinga.com
    • Splitting into separate files is achieved by using conditions within 02-installation.md. Based on the conditions the script parse_templates.py from https://github.com/icinga/icinga-docs-tools separates the installation instructions into files during the generation of the docs for icinga.com
  • Introduces new supported systems like Amazon Linux 2
  • Updates installation instructions, especially for RHEL, SLES and AL2
  • Cleans up some old paragraphs
  • Re-arranges the different sections to make the installation process more clear

@bobapple bobapple requested a review from julianbrost February 16, 2022 09:31
@icinga-probot icinga-probot bot added this to the 2.13.3 milestone Feb 16, 2022
@bobapple
Copy link
Member Author

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Feb 16, 2022
@julianbrost
Copy link
Contributor

@bobapple Will you ensure that these changes are also forward-ported to the master branch?

Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes already received some rounds of internal review, so the current version is fine for me.

Changes still have to be forward ported to master but there are some conflicts that one has to manually look into and resolve for which I don't have time right now, so I created #9218 for now so that it won't be forgotten.

@julianbrost julianbrost merged commit 3b15ae5 into support/2.13 Feb 16, 2022
@icinga-probot icinga-probot bot deleted the feature/installation-instructions branch February 16, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants