-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TLS 1.3 #8718
Merged
Merged
Support TLS 1.3 #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
force-pushed
the
feature/tls-1.3
branch
4 times, most recently
from
April 15, 2021 10:23
447b3d6
to
8c2706d
Compare
Noteworthy limitation of this PR: There is currently no way to configure the set of accepted cipher suites for TLS 1.3. Icinga currently uses So there are a few options now:
|
I would do it that way. |
Merged
Al2Klimov
requested changes
Jun 23, 2021
julianbrost
force-pushed
the
feature/tls-1.3
branch
from
June 29, 2021 09:09
8c2706d
to
0e7a05a
Compare
Al2Klimov
approved these changes
Jun 29, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TLS 1.3.
Unfortunately, there's no method value for
ssl::context
that specifies TLS 1.2 or newer but only any TLS version, i.e. TLS 1.0 or newer (https://www.boost.org/doc/libs/1_75_0/doc/html/boost_asio/reference/ssl__context/method.html). That's not too much of an issue though as the call toSetupSslContext()
will disable TLS 1.0 and 1.1.fixes #8715