Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implement support for own ECC certificates #7322

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Implement support for own ECC certificates #7322

wants to merge 1 commit into from

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Jul 15, 2019 •
edited
Loading

fixes #7323

@dnsmichi dnsmichi mentioned this pull request Jul 15, 2019
Open
6 tasks
@dnsmichi dnsmichi added the stalled Blocked or not relevant yet label Jul 16, 2019
@dasJ
Copy link
Contributor

dasJ commented Jul 18, 2019 •
edited
Loading

Nice, that looks like an awesome feature.
I'd really like to test this (although I'm aware this is WIP), so what's the state of this? If I create a cluster from scratch (so there are no RSA keys) with this PR applied, should everything just work out?

Btw, nice commit hash ;)

@dnsmichi
Copy link
Contributor Author

See the linked issue #7323 for blockers. I don't think that this qualifies any time soon with having old clients which don't know ECC nor the cipher suites. The PR should work, but hasn't been tested extensively. It is a PoC for now.

@dnsmichi dnsmichi added area/distributed Distributed monitoring (master, satellites, clients) area/setup Installation, systemd, sample files labels Nov 15, 2019
@Al2Klimov Al2Klimov marked this pull request as draft June 29, 2020 11:15
@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Nov 23, 2020
@julianbrost julianbrost removed this from the 2.13.0 milestone May 31, 2021
@Al2Klimov
Copy link
Member

Had a look around what's exactly the EL7 showstopper. At least EL7<->EL7 nodes purred like a 🐈.

@Al2Klimov Al2Klimov changed the title WIP: Implement support for ECC certificates WIP: Implement support for own ECC certificates Mar 26, 2024
Al2Klimov
Al2Klimov reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: https://miracl.com/blog/backdoors-in-nist-elliptic-curves/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al2Klimov Al2Klimov Al2Klimov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/distributed Distributed monitoring (master, satellites, clients) area/setup Installation, systemd, sample files stalled Blocked or not relevant yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non-external ECC certificates
4 participants
@dnsmichi @dasJ @Al2Klimov @julianbrost