Remove double whitespaces for notifications log message #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add space to checkable debug message to unify timestamp format
|
@htriem Please have a look. |
|
I've applied and tested the commit.
Everything appears to be in working order, and the log output is looking like we want it to. Nice work, @Crited! 👍 |
htriem
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add space to checkable debug message to unify timestamp format:
Behavior before: Update checkable 'c2-mysql-2!ping4' with check interval '60' from last check time at 2019-05-22 14:17:52 +0200 (1.55853e+09) to next check time at 2019-05-22 14:18:49 +0200(1.55853e+09).
Expected behavior: Update checkable 'c2-mysql-2!ping4' with check interval '60' from last check time at 2019-05-22 14:17:52 +0200 (1.55853e+09) to next check time at 2019-05-22 14:18:49 +0200 (1.55853e+09).
Remove double whitespaces for notifications log message.
Behavior before: Attempting to send notifications for notification object 'icinga2.1.vagrant.demo.icinga.com!random-001!mail-icingaadmin'.
Expected behavior: Attempting to send notifications for notification object 'icinga2.1.vagrant.demo.icinga.com!random-001!mail-icingaadmin'.
Yet, I am not sure if this is the best way of solving this problem.