Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all perfdata to be written #6908

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Ensure all perfdata to be written #6908

merged 4 commits into from
Feb 11, 2019

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov self-assigned this Jan 24, 2019
@Al2Klimov Al2Klimov force-pushed the bugfix/perfdata-gaps branch from 8e081f2 to 1eaad06 Compare January 24, 2019 14:09
@Al2Klimov Al2Klimov changed the title WIP: Ensure all perfdata to be written Ensure all perfdata to be written Jan 24, 2019
@Al2Klimov Al2Klimov requested a review from lippserd January 24, 2019 14:19
@Al2Klimov Al2Klimov removed their assignment Jan 24, 2019
@dnsmichi dnsmichi added the area/checks Check execution and results label Feb 4, 2019
@dnsmichi
Copy link
Contributor

dnsmichi commented Feb 4, 2019

Notes as discussed offline:

  • Defer borrowed from Golang makes sense
  • activation priority as no effect on Stop(), needs to be re-visited

@lippserd putting this on-hold for now up until @Al2Klimov looks into it again.

@dnsmichi dnsmichi mentioned this pull request Feb 4, 2019
Merged
@dnsmichi dnsmichi added the needs feedback We'll only proceed once we hear from you again label Feb 4, 2019
@Al2Klimov Al2Klimov requested a review from dnsmichi February 6, 2019 10:23
@lippserd lippserd mentioned this pull request Feb 6, 2019
Closed
@Al2Klimov
Copy link
Member Author

@lippserd I've corrected the mistake @dnsmichi pointed out. What about building "snapshot packages" from #6882 + this one and let the customer test?

@Al2Klimov Al2Klimov removed their assignment Feb 11, 2019
@dnsmichi
Copy link
Contributor

Are you able to reproduce the mentioned "killed" checks in #6873?

@Al2Klimov
Copy link
Member Author

I didn't even try. But the user affected by the problem could test snapshot packages.

@dnsmichi dnsmichi added this to the 2.11.0 milestone Feb 11, 2019
@dnsmichi
Copy link
Contributor

Ok, then let's go.

@dnsmichi dnsmichi merged commit 0467c48 into master Feb 11, 2019
@Al2Klimov Al2Klimov deleted the bugfix/perfdata-gaps branch February 11, 2019 16:28
@ix-dev ix-dev mentioned this pull request Feb 18, 2019
Closed
@dnsmichi dnsmichi mentioned this pull request Feb 25, 2019
Merged
@dnsmichi dnsmichi removed the needs feedback We'll only proceed once we hear from you again label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd Awaiting requested review from lippserd

@dnsmichi dnsmichi Awaiting requested review from dnsmichi

Assignees
No one assigned
Labels
area/checks Check execution and results
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @dnsmichi