-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpUtility::SendJsonBody(): auto-sanitize non-UTF-8 JSON #6809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test protocol
Both the API response and the state file look fine. |
Al2Klimov
changed the title
HttpUtility::SendJsonBody(): auto-sanitize non-UTF-8 JSON
WIP: HttpUtility::SendJsonBody(): auto-sanitize non-UTF-8 JSON
Nov 30, 2018
Al2Klimov
force-pushed
the
bugfix/non-utf-8-broken-json-4703
branch
from
November 30, 2018 09:39
47b7d99
to
154df7b
Compare
Al2Klimov
changed the title
WIP: HttpUtility::SendJsonBody(): auto-sanitize non-UTF-8 JSON
HttpUtility::SendJsonBody(): auto-sanitize non-UTF-8 JSON
Nov 30, 2018
In addition the API query results differ.
|
I will be working on #6684 soon and replace the entire JSON library causing memory leaks. When at it, I'll test this PR too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4703