Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make strings valid UTF-8 before JSON-encoding them #5014

Closed
wants to merge 1 commit into from
Closed

WIP: Make strings valid UTF-8 before JSON-encoding them #5014

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

fixes #4703

@dnsmichi dnsmichi added the needs feedback We'll only proceed once we hear from you again label Mar 10, 2017
@dnsmichi dnsmichi changed the title Make strings valid UTF-8 before JSON-encoding them WIP: Make strings valid UTF-8 before JSON-encoding them Jun 16, 2017
@Crunsher
Copy link
Contributor

Crunsher commented Oct 5, 2017

@Al2Klimov Any update on this? As @dnsmichi mentioned Utility::ValidateUTF8() is too expensive to use here.

Maybe there is a better way in the mindset of "don't ask for permission, ask for forgiveness" by forcing it to UTF8 and living with a possibly garbled output

@Al2Klimov
Copy link
Member Author

@Crunsher Maybe there is another developer w/ a mindset of "I have time to do this stuff carefully". Right now I am focussed on a bunch of non-Icinga2 things.

Btw I still think that my fix is "the right way" to do this as JSON has to be UTF8-encoded.

@dnsmichi
Copy link
Contributor

dnsmichi commented Oct 6, 2017

@Crunsher I would create a reminder/discussion ticket if not already existing and close this PR. This won't be merged anyways.

@dnsmichi dnsmichi closed this Oct 9, 2017
@dnsmichi dnsmichi removed the needs feedback We'll only proceed once we hear from you again label Oct 9, 2017
@Al2Klimov Al2Klimov deleted the bugfix/non-utf-8-characters-create-broken-json-4703 branch November 29, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev.icinga.com #12829] non-UTF-8 characters creates broken JSON
3 participants