Introduce Endpoint#seconds_{reading_messages,awaiting_semaphore,processing_messages} #10266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
force-pushed
the
json-rpc-read-process-metrics
branch
2 times, most recently
from
5d1b07f to
92a4f45
Compare
Al2Klimov
changed the title
Al2Klimov
commented
Dec 10, 2024
Al2Klimov
force-pushed
the
json-rpc-read-process-metrics
branch
from
ef2a7d3 to
3ebbfc6
Compare
Al2Klimov
commented
Dec 10, 2024
|
|
||
| [no_user_modify, no_storage] double seconds_processing_messages { | ||
| get; | ||
| }; |
There was a problem hiding this comment.
It works! 👍
< HTTP/1.1 200 OK
< Server: Icinga/v2.14.0-375-gecea52568
< Content-Type: application/json
< Content-Length: 591
<
{
"results": [
{
"attrs": {
"seconds_processing_messages": 3.1292e-05,
"seconds_reading_messages": 0.000155709
},
"joins": {},
"meta": {},
"name": "dummy",
"type": "Endpoint"
},
{
"attrs": {
"seconds_processing_messages": 0,
"seconds_reading_messages": 0
},
"joins": {},
"meta": {},
"name": "ws-aklimov7777777.local",
"type": "Endpoint"
}
]
}
3ebbfc6 to
f845407
Compare
Al2Klimov
commented
Dec 10, 2024
| new PerfdataValue("sum_bytes_received_per_second", bytesReceivedPerSecond) | ||
| new PerfdataValue("sum_bytes_received_per_second", bytesReceivedPerSecond), | ||
| new PerfdataValue("sum_seconds_reading_messages", secondsReadingMessages), | ||
| new PerfdataValue("sum_seconds_processing_messages", secondsProcessingMessages) |
There was a problem hiding this comment.
{
"counter": false,
"crit": null,
"label": "sum_seconds_reading_messages",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 0.000787875,
"warn": null
},
{
"counter": false,
"crit": null,
"label": "sum_seconds_processing_messages",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 3.45e-05,
"warn": null
}
| @@ -148,6 +152,8 @@ void IcingaCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckRes | |||
| perfdata->Add(new PerfdataValue("sum_messages_received_per_second", messagesReceivedPerSecond)); | |||
| perfdata->Add(new PerfdataValue("sum_bytes_sent_per_second", bytesSentPerSecond)); | |||
| perfdata->Add(new PerfdataValue("sum_bytes_received_per_second", bytesReceivedPerSecond)); | |||
| perfdata->Add(new PerfdataValue("sum_seconds_reading_messages", secondsReadingMessages)); | |||
| perfdata->Add(new PerfdataValue("sum_seconds_processing_messages", secondsProcessingMessages)); | |||
There was a problem hiding this comment.
{
"counter": false,
"crit": null,
"label": "sum_seconds_reading_messages",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 0.000264792,
"warn": null
},
{
"counter": false,
"crit": null,
"label": "sum_seconds_processing_messages",
"max": null,
"min": null,
"type": "PerfdataValue",
"unit": "",
"value": 5.2666e-05,
"warn": null
}
Al2Klimov
commented
Dec 10, 2024
| get; | ||
| }; | ||
|
|
||
| [no_user_modify, no_storage] double seconds_processing_messages { |
There was a problem hiding this comment.
Colleagues, addition we could also (just for the API) record seconds_processing_messages PER message. I.e. there should be also another attribute returning a dict like {"event::CheckResult":42.0,... saying that this endpoint e.g. spent 42 seconds handling (already read and decoded) event::CheckResult messages since program start.
There was a problem hiding this comment.
- Yes, there's also Log HTTP/RPC message processing stats #10141, but it's debug log unless a singe message takes excessively long. So, unless combined with Logger#object_filter: restrict Logger to messages referring to specific objects #9844, it's pretty useless in a large env.
Al2Klimov
force-pushed
the
json-rpc-read-process-metrics
branch
from
f845407 to
20460e6
Compare
Al2Klimov
force-pushed
the
json-rpc-read-process-metrics
branch
from
20460e6 to
055c6b6
Compare
Al2Klimov
changed the title
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref/NC/820479
Tests