Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-IcingaCheckMemory - please add commited memory #14

Closed
puseidr opened this issue Feb 13, 2020 · 1 comment · Fixed by #177
Closed

Invoke-IcingaCheckMemory - please add commited memory #14

puseidr opened this issue Feb 13, 2020 · 1 comment · Fixed by #177
Assignees
@LordHepipud
Labels
enhancement New feature or request
Milestone
v1.5.0

Comments

@puseidr
Copy link

puseidr commented Feb 13, 2020

in the current version (1.0.0.-rc1 stable) the Invoke-IcingaCheckMemory cmdlet only looks at the physical memory.
Could you please add the commited memory for the calculation (warning/crit) and performancedata.

The commited memory is more importend for a windows administrator then the physical (wich is often not full, but the pagefile has a fixed size and is not auto-growing)
@LordHepipud
Copy link
Collaborator

We will add an additional check for monitoring the page file, to ensure we do not crowd one plugin with too many content and arguments for now.

This one is already on our roadmap including with some other topics.

Thank you for the info

@LordHepipud LordHepipud self-assigned this Feb 13, 2020
@LordHepipud LordHepipud added the enhancement New feature or request label Feb 13, 2020
@LordHepipud LordHepipud added this to the v1.1.0 milestone May 8, 2020
@LordHepipud LordHepipud modified the milestones: v1.1.0, v.1.2.0 Jun 3, 2020
@LordHepipud LordHepipud modified the milestones: v.1.2.0, v1.3.0 Aug 27, 2020
@LordHepipud LordHepipud modified the milestones: v1.3.0, v1.4.0 Nov 26, 2020
@LordHepipud LordHepipud removed this from the v1.4.0 milestone Feb 24, 2021
@LordHepipud LordHepipud added this to the v1.5.0 milestone May 19, 2021
@LordHepipud LordHepipud mentioned this issue May 28, 2021
Merged
LordHepipud added a commit that referenced this issue May 28, 2021
@LordHepipud
Merge pull request #177 from Icinga:feature/add_pagefile_to_memory_check
e2ca187 
Feature: Improves Invoke-IcingaCheckMemory and adds PageFile checks

Rework of `Invoke-IcingaCheckMemory` to use new features from 1.5.0 for % handling and added page file check content including arguments. Please have a look on the [upgrading docs](https://icinga.com/docs/icinga-for-windows/latest/plugins/doc/30-Upgrading-Plugins/)

Please note that `WarningPercent` and `CriticalPercent` were removed. You can add % Thresholds to the regular arguments now.

Fixes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LordHepipud LordHepipud

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Feature: Improves Invoke-IcingaCheckMemory and adds PageFile checks Icinga/icinga-powershell-plugins
2 participants
@puseidr @LordHepipud