Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: in the Server header, identify the software, not the machine #743

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Al2Klimov
Copy link
Member

Rationale: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Server

Test

> GET /v1/checker?command=cpu HTTP/1.1
> Host: 10.27.0.147:5668
> User-Agent: curl/8.6.0
> Accept: */*
>
< HTTP/1.1 200 Ok
< Server: IcingaForWindows/1.12.3
< Content-Type: application/json
< Content-Length: 427
<

@cla-bot cla-bot bot added the cla/signed label Jul 11, 2024
@LordHepipud LordHepipud added this to the v1.13.0 milestone Aug 14, 2024
@LordHepipud LordHepipud added the Bug There is an issue present label Aug 14, 2024
@LordHepipud
Copy link
Collaborator

Thank you very much for the PR. Could you please update the changelog alongside with the following:

### Bugfixes

* [#743](https://github.com/Icinga/icinga-powershell-framework/pull/743) Fixes REST-Api response header to report the software instead of the machine name

@LordHepipud LordHepipud merged commit 5bbba96 into Icinga:master Aug 19, 2024
1 check passed
@LordHepipud
Copy link
Collaborator

Thanks!

@Al2Klimov Al2Klimov deleted the REST-Server-header branch August 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is an issue present cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants