Feature: Improve cache file writer with more robust handling #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
fix/more_secure_handling_to_wrote_cache_files
branch
from
50a82d1
to
744ff74
Compare
LordHepipud
force-pushed
the
fix/more_secure_handling_to_wrote_cache_files
branch
from
744ff74
to
b846402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that new cache files will always be written inside a
.tmpfile at the same location and tested for validation before applied to the regular file via copy.This should prevent files becoming corrupt in the future during write operations.