Fix: Adds DSL parser to string arguments to fix whitespace and $ escaping #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
added
Bug
LordHepipud
changed the title
LordHepipud
changed the title
LordHepipud
force-pushed
the
fix/icinga_config_string_dsl
branch
from
28fad0a
to
a43d7aa
Compare
LordHepipud
force-pushed
the
fix/icinga_config_string_dsl
branch
from
a43d7aa
to
9602db9
Compare
LordHepipud
force-pushed
the
fix/icinga_config_string_dsl
branch
from
9602db9
to
f126065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with current implementation, as string values containing whitespaces or
$are rendered wrong by default, if not set in single quotes''Example:
Using
My Servicewill output
MyServiceThis issue is already fixed for arrays, but plain string values on arguments require this workaround.
As Icinga 2 will always set arguments if a DSL is specified, regardless if a value is present or not, we have to use a
set_ifexpression for this, but can't as the Icinga Director baskets currently ignoreset_if_formatwhich requires to be an expression instead of a string.Icinga/icingaweb2-module-director#2291
This PR is pending as long as the Director issue is not fixed and released within a release.