Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules for apilistener logs #36

Merged
merged 1 commit into from
May 31, 2019
Merged

Add rules for apilistener logs #36

merged 1 commit into from
May 31, 2019

Conversation

Crited
Copy link
Member

@Crited Crited commented May 29, 2019

Added a rule for apilistener logs

refers to #2

@widhalmt
Copy link
Member

We do have a field named clientendpoint, maybe that would fit better in your pattern? Could you check that and reply here?

Besides: Please leave a comment with # explaining the change to the if condition. You explained to me in person but we both will forget within weeks why this extra regex is needed and we might remove it for performance reasons.

@Crited
Copy link
Member Author

Crited commented May 31, 2019

clientendpoint fits way better, because mine was straight up wrong. Thanks!

I also added a comment as you suggested. Relaying information here, should have thought of that.

@widhalmt
Copy link
Member

Perfect! Merged.

@widhalmt widhalmt merged commit 9ca5f07 into Icinga:master May 31, 2019
@Crited Crited deleted the feature/apilistener_2 branch June 18, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants