Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vitest, extract renderSize helper #235

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Add vitest, extract renderSize helper #235

merged 3 commits into from
Jul 31, 2024

Conversation

malykhinvi
Copy link
Contributor

@malykhinvi malykhinvi commented Jul 19, 2024 •
edited
Loading

  1. Extract duplicated renderSize function
  2. Add vitest for unit testing
  3. Add ci GH workflow to run tests on CI
  4. Remove ZB and YB support. Due to precision loss in JS number type, these sizes are not supported. JS number supports only 2^53

@malykhinvi malykhinvi marked this pull request as ready for review July 19, 2024 10:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CorrectRoadH
Copy link
Member

LGTM

@CorrectRoadH CorrectRoadH merged commit 882369b into IceWhaleTech:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malykhinvi @CorrectRoadH