fix: fix update status not update (#184)

IceWhaleTech · Apr 12, 2024 · 05c9cb9 · 05c9cb9
1 parent e8eb754
commit 05c9cb9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/route/v2/compose_app.go b/route/v2/compose_app.go
@@ -461,9 +461,6 @@ func (a *AppManagement) UpdateComposeApp(ctx echo.Context, id codegen.ComposeApp
 
 	backgroundCtx := common.WithProperties(context.Background(), PropertiesFromQueryParams(ctx))
 
-	service.MyService.AppStoreManagement().StartUpgrade(id)
-	defer service.MyService.AppStoreManagement().FinishUpgrade(id)
-
 	if err := composeApp.Update(backgroundCtx); err != nil {
 		logger.Error("failed to update compose app", zap.Error(err), zap.String("appID", id))
 		message := err.Error()

diff --git a/service/compose_app.go b/service/compose_app.go
@@ -226,6 +226,9 @@ func (a *ComposeApp) Update(ctx context.Context) error {
 
 		defer PublishEventWrapper(ctx, common.EventTypeAppUpdateEnd, nil)
 
+		MyService.AppStoreManagement().StartUpgrade(a.Name)
+		defer MyService.AppStoreManagement().FinishUpgrade(a.Name)
+
 		if err := a.PullAndApply(ctx, newComposeYAML); err != nil {
 			go PublishEventWrapper(ctx, common.EventTypeAppUpdateError, map[string]string{
 				common.PropertyTypeMessage.Name: err.Error(),