Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.1.0 - updates #56

Merged
merged 7 commits into from
Nov 5, 2024
Merged

3.1.0 - updates #56

merged 7 commits into from
Nov 5, 2024

Conversation

physik932
Copy link
Collaborator

Description

Updating to Node 20, testing dependabot changes

Fixes # (issue)

Type of change

Maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Browser Version: Firefox 130.0.0 20240829075237
  • Operating System: macOS Sonoma 14.6.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@physik932 physik932 self-assigned this Sep 17, 2024
@physik932 physik932 added the work in progress When the feature is in progress label Sep 17, 2024
@ibcheckmarx
Copy link

ibcheckmarx commented Sep 17, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 53b02738-52b6-4252-bc28-028021e07b64

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Cx89601373-08db Npm-debug-3.2.7 Vulnerable Package
HIGH Cx89601373-08db Npm-debug-2.6.9 Vulnerable Package
HIGH Cx8bc4df28-fcf5 Npm-debug-4.3.7 Vulnerable Package
HIGH Cx8bc4df28-fcf5 Npm-debug-2.6.9 Vulnerable Package
HIGH Cx8bc4df28-fcf5 Npm-debug-3.2.7 Vulnerable Package
HIGH Cxdca8e59f-8bfe Npm-inflight-1.0.6 Vulnerable Package
MEDIUM Cx14b19a02-387a Npm-body-parser-1.20.3 Vulnerable Package

Fixed Issues

Severity Issue Source File / Package
LOW Missing_CSP_Header /src/templates/iframe.html: 1
LOW Potential_Clickjacking_on_Legacy_Browsers /src/templates/iframe.html: 1
LOW Unsafe_Use_Of_Target_blank /src/templates/default.js: 10
LOW Unsafe_Use_Of_Target_blank /src/templates/error.js: 12

John-CX-Guy
John-CX-Guy reviewed Nov 5, 2024
View reviewed changes
Copy link

@John-CX-Guy John-CX-Guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

lebeerman
lebeerman approved these changes Nov 5, 2024
View reviewed changes
Copy link

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@physik932 physik932 added enhancement New feature or request and removed work in progress When the feature is in progress labels Nov 5, 2024
@physik932 physik932 merged commit 65a9d44 into main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-CX-Guy John-CX-Guy John-CX-Guy approved these changes

@lebeerman lebeerman lebeerman approved these changes

Assignees

@physik932 physik932

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@physik932 @ibcheckmarx @lebeerman @John-CX-Guy