Skip to content

Commit

Permalink
narrower, fix some compat issues
Browse files Browse the repository at this point in the history
  • Loading branch information
onyxraven committed Aug 19, 2024
1 parent 0a8be8e commit 66fcdd2
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 16 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,22 @@ jobs:
matrix:
ruby-version:
- "3.0"
- "3.1"
- "3.2"
- "3.3"
# - "3.1"
# - "3.2"
# - "3.3"
resque-version:
- "master"
- "~> 2.6"
# - "master"
# - "~> 2.6"
- "~> 1.27"
rufus-scheduler:
- "~> 3.6.0"
- "~> 3.7.0"
# - "~> 3.6.0"
# - "~> 3.7.0"
- "~> 3.8.0"
- "~> 3.9"
redis-version:
- "~> 3.3"
- "~> 4.8"
- "~> 5.2"
# - "~> 5.2"
exclude:
- resque-version: "~> 1.27"
redis-version: "~> 5.x"
Expand All @@ -57,7 +57,7 @@ jobs:
RUFUS_SCHEDULER: "${{ matrix.rufus-scheduler }}"
COVERAGE: 1

name: "ruby: ${{matrix.ruby-version}}, resque ${{matrix.resque-version}}, rufus-scheduler ${{matrix.rufus-scheduler}}, redis-rb ${{matrix.redis-version}}"
name: "ruby ${{matrix.ruby-version}}, resque ${{matrix.resque-version}}, rufus-scheduler ${{matrix.rufus-scheduler}}, redis-rb ${{matrix.redis-version}}"

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# vim:fileencoding=utf-8
source 'https://rubygems.org'

case resque_version = ENV.fetch('RESQUE', 'master')
case resque_version = ENV.fetch('RESQUE', 'latest')
when 'master'
gem 'resque', git: 'https://github.com/resque/resque'
when 'latest'
Expand Down
16 changes: 12 additions & 4 deletions test/delayed_queue_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# vim:fileencoding=utf-8
require_relative 'test_helper'

def assert_resque_key_exists?(key)
if Gem::Requirement.create('< 4').satisfied_by?(Gem::Version.create(Redis::VERSION))
assert(!Resque.redis.exists(key))
else
assert(!Resque.redis.exists?(key))
end
end

context 'DelayedQueue' do
setup do
Resque::Scheduler.quiet = true
Expand Down Expand Up @@ -41,7 +49,7 @@
'Should have the same arguments that we queued')

# And now confirm the keys are gone
assert(!Resque.redis.exists?("delayed:#{timestamp.to_i}"))
assert_resque_key_exists?("delayed:#{timestamp.to_i}")
assert_equal(0, Resque.redis.zcard(:delayed_queue_schedule),
'delayed queue should be empty')
assert_equal(0, Resque.redis.scard("timestamps:#{encoded_job}"),
Expand Down Expand Up @@ -84,7 +92,7 @@
'Should have the queue that we asked for')

# And now confirm the keys are gone
assert(!Resque.redis.exists?("delayed:#{timestamp.to_i}"))
assert_resque_key_exists?("delayed:#{timestamp.to_i}")
assert_equal(0, Resque.redis.zcard(:delayed_queue_schedule),
'delayed queue should be empty')
assert_equal(0, Resque.redis.scard("timestamps:#{encoded_job}"),
Expand Down Expand Up @@ -1053,7 +1061,7 @@
assert_equal(
1, Resque.remove_delayed_job_from_timestamp(t, SomeIvarJob, 'foo')
)
assert !Resque.redis.exists?("delayed:#{t.to_i}")
assert_resque_key_exists?("delayed:#{t.to_i}")
assert Resque.delayed_queue_peek(0, 100).empty?
end

Expand Down Expand Up @@ -1094,7 +1102,7 @@
Resque.enqueue_at(timestamp, SomeIvarJob, 'foo', 'bar')

assert_equal 0, Resque.count_all_scheduled_jobs
assert !Resque.redis.exists?("delayed:#{timestamp.to_i}")
assert_resque_key_exists?("delayed:#{timestamp.to_i}")
ensure
Resque.inline = false
end
Expand Down
4 changes: 2 additions & 2 deletions test/resque-web_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ module Test
test 'redirects to overview' do
post '/delayed/cancel_now'
assert last_response.status == 302
assert last_response.header['Location'].include? '/delayed'
assert last_response.headers['Location'].include? '/delayed'
end
end

Expand All @@ -316,7 +316,7 @@ module Test

test 'redirects to delayed' do
assert last_response.status == 302
assert last_response.header['Location'].include? '/delayed'
assert last_response.headers['Location'].include? '/delayed'
end
end

Expand Down
1 change: 1 addition & 0 deletions test/scheduler_test.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# vim:fileencoding=utf-8
require_relative 'test_helper'
require 'ostruct'

context 'Resque::Scheduler' do
setup do
Expand Down

0 comments on commit 66fcdd2

Please sign in to comment.