-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Unwrap
module for dispatching on unwrapped types
#1220
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
===========================================
- Coverage 82.87% 54.54% -28.34%
===========================================
Files 89 88 -1
Lines 8440 8392 -48
===========================================
- Hits 6995 4577 -2418
- Misses 1445 3815 +2370
☔ View full report in Codecov by Sentry. |
iswrappedarray
function…Unwrap
module for dispatching on unwrapped types
@kmp5VT I fixed the merge conflicts. This looks good to go from my end, is this ready from your end? Any more scalar indexing issues you wanted to address? |
Ah looks like some tests are failing, I introduced code into |
…xes issues but returns again a Transpose of `V` so test is still broken
….jl into kmp5/enhancements/unwrap
Yeah I found those areas and fixed them |
@mtfishman Okay this PR should be good now. Thanks! |
Description
In this PR I attempt to address issues we are having with generic programming. This issue is that wrapped arrays can become too complicated for Julia to parse correctly for dispatch and as a result, incorrect functions are called which in turn slows down the code. Here I am creating a simple
Expose
type which will determine the base unwrapped type and launch the appropriate kernels based on this type.This will fix #1193 (we should confirm that before merging).
Checklist:
expose
struct