Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around viper bug #1106 #172

Closed
pgalbavy-itrs opened this issue Jul 28, 2023 · 0 comments · Fixed by #173
Closed

Work around viper bug #1106 #172

pgalbavy-itrs opened this issue Jul 28, 2023 · 0 comments · Fixed by #173
Assignees
@pgalbavy-itrs
Labels
bug Something isn't working

Comments

@pgalbavy-itrs
Copy link
Collaborator

Viper has a bug (spf13/viper#1106) that means Get and all derivatives fail to get all elements of a map (or unmarshal) where an element has been set after defaults etc.

Implement a variety of spf13/viper#1504 to work around this without duplicating the whole codebase.
@pgalbavy-itrs pgalbavy-itrs added the bug Something isn't working label Jul 28, 2023
@pgalbavy-itrs pgalbavy-itrs self-assigned this Jul 28, 2023
pgalbavy-itrs added a commit that referenced this issue Jul 28, 2023
@pgalbavy-itrs
Work around viper bug #1106
e236f57 
Fixes #172
@pgalbavy-itrs pgalbavy-itrs mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgalbavy-itrs pgalbavy-itrs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Work around viper bug #1106 ITRS-Group/cordial
1 participant
@pgalbavy-itrs