Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix replaceTokens function #6539

Merged
merged 2 commits into from
Oct 15, 2024
Merged

🐛 [Frontend] Fix replaceTokens function #6539

merged 2 commits into from
Oct 15, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 15, 2024 •
edited
Loading

What do these changes do?

The replaceTokens function was buggy for localized strings, making the Plus Button creation fail

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 15, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 15, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz enabled auto-merge (squash) October 15, 2024 13:39
@pcrespov pcrespov disabled auto-merge October 15, 2024 13:41
@pcrespov pcrespov merged commit 5b8fd1a into ITISFoundation:master Oct 15, 2024
34 of 36 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 15, 2024
Closed
18 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@GitHK GitHK Awaiting requested review from GitHK

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
2 participants
@odeimaiz @pcrespov