Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 New sql script template to remove readonly user #6500

Merged
merged 7 commits into from
Oct 8, 2024
Merged

🔨 New sql script template to remove readonly user #6500

merged 7 commits into from
Oct 8, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 8, 2024 •
edited
Loading

What do these changes do?

Extends templates in services/postgres/scripts to assist with creation and removal of readonly postgres accounts

  • 🔨 new sql script template to remove readonly user
  • New default for POSTGRES_READONLY_USER=postgres_readonly in development .env-devel

Related issue/s

How to test

Tested manually in local db
image

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Oct 8, 2024
@pcrespov pcrespov changed the title WIP: 🔨 Mai/script drop users 🔨 New sql script template to remove readonly user Oct 8, 2024
@pcrespov pcrespov marked this pull request as ready for review October 8, 2024 13:45
@pcrespov pcrespov added a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work labels Oct 8, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 8, 2024
@pcrespov pcrespov enabled auto-merge (squash) October 8, 2024 13:46
matusdrobuliak66
matusdrobuliak66 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov disabled auto-merge October 8, 2024 16:34
@pcrespov pcrespov merged commit 997eeb3 into ITISFoundation:master Oct 8, 2024
2 checks passed
@pcrespov pcrespov deleted the mai/script-drop-users branch October 8, 2024 16:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 14, 2024
@pcrespov @mrnicegyu11
🔨 New sql script template to remove readonly user (ITISFoundation#6500)
26e7fd6
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 15, 2024
Closed
18 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@pcrespov pcrespov

Labels
a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
2 participants
@pcrespov @matusdrobuliak66