Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Announcements: allow in ribbon only #6440

Merged
merged 11 commits into from
Sep 25, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 25, 2024

What do these changes do?

Right now, all announcements are shown in the login page.

  • Fix: Check if announcement goes in "login"
  • Enh: Center texts in login page's announcement
  • Enh: Make description optional

Before:
image

After:
image

Related issue/s

related to ITISFoundation/osparc-issues#1701

How to test

Dev-ops checklist

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Sep 25, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 25, 2024
@odeimaiz odeimaiz self-assigned this Sep 25, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link

@odeimaiz odeimaiz merged commit b6532c1 into ITISFoundation:master Sep 25, 2024
51 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants