-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 rabbitmq queue name prefix is unique during the lifecycle of the container #6365
🐛 rabbitmq queue name prefix is unique during the lifecycle of the container #6365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.4%
=========================================
Files 10 1183 +1173
Lines 214 52191 +51977
Branches 25 1078 +1053
=========================================
+ Hits 181 45924 +45743
- Misses 23 6078 +6055
- Partials 10 189 +179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
…parc-simcore-forked into pr-osparc-change-rabbitmq-names
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx.
The description and the changes do not fit for me . Is it perhaps obsolete or I missed something? :-)
What do these changes do?
Rabbit queue name prefix is no longer derived just from the host name. It is now extended with the last 6 characters of the processes' start time.
The changes allow to maintain the old behaviour and also permit restorability of the services without the webserver continuously failing to start, like it did in the past.
Highlights on updated libraries (only updated libraries are included)
clusters-keeper⬆️🧪
dask-sidecar⬆️⬆️
director-v2⬆️🧪
dynamic-sidecar⬆️
osparc-gateway-server🧪🧪
Legend:
Repo-wide overview of libraries
Related issue/s
How to test
Dev-ops checklist