Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 viewers can now use new style dynamic services #6023

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 3, 2024

What do these changes do?

Viewers based on new style services, running via dynamic-sidecar, can now be used.

  • 🐛 Fixes an issue where generated projects did not update the project_networks table. This did not allow for the dynamic-sidecar to start.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jul 3, 2024
@GitHK GitHK added bug buggy, it does not work as expected a:static-webserver static-webserver service a:webserver issue related to the webserver service and removed a:static-webserver static-webserver service labels Jul 3, 2024
@GitHK GitHK added this to the South Island Iced Tea milestone Jul 3, 2024
@GitHK GitHK changed the title fix missing projects entry for dynamic sidecar based services 🐛 viewers can now use new style dynamic services Jul 3, 2024
@GitHK GitHK marked this pull request as ready for review July 3, 2024 08:30
@GitHK GitHK requested a review from odeimaiz July 3, 2024 08:30
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (cafbf96) to head (4a8a190).
Report is 315 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6023      +/-   ##
=========================================
- Coverage    84.5%   81.5%    -3.1%     
=========================================
  Files          10     561     +551     
  Lines         214   28505   +28291     
  Branches       25     205     +180     
=========================================
+ Hits          181   23244   +23063     
- Misses         23    5210    +5187     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 63.6% <25.0%> (?)
unittests 87.3% <100.0%> (+2.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ebserver/studies_dispatcher/_redirects_handlers.py 87.1% <100.0%> (ø)

... and 570 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new function covered by the studies_dispatcher tests, if not please add some checks thx

@GitHK GitHK enabled auto-merge (squash) July 3, 2024 10:43
@GitHK GitHK merged commit 9f0cf48 into ITISFoundation:master Jul 3, 2024
56 checks passed
@GitHK GitHK deleted the pr-osparc-patch-view-dy-sidecar branch July 3, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants