-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 viewers can now use new style dynamic services #6023
🐛 viewers can now use new style dynamic services #6023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6023 +/- ##
=========================================
- Coverage 84.5% 81.5% -3.1%
=========================================
Files 10 561 +551
Lines 214 28505 +28291
Branches 25 205 +180
=========================================
+ Hits 181 23244 +23063
- Misses 23 5210 +5187
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new function covered by the studies_dispatcher tests, if not please add some checks thx
What do these changes do?
Viewers based on new style services, running via dynamic-sidecar, can now be used.
Related issue/s
How to test
Dev-ops checklist